Skip to content

fix: Fixes warning logged on double-initialize of prefabs lists.#2565

Merged
NoelStephensUnity merged 3 commits intodevelopfrom
fix/handle_prefab_double_initialize
May 20, 2023
Merged

fix: Fixes warning logged on double-initialize of prefabs lists.#2565
NoelStephensUnity merged 3 commits intodevelopfrom
fix/handle_prefab_double_initialize

Conversation

@ShadauxCat
Copy link
Copy Markdown
Collaborator

Also, makes adding prefabs before initializing the list no longer an error case - those prefabs are stored in a separate list so that during initialization, they can be re-added to the prefabs list after pulling in data from the NetworkPrefabsList ScriptableObjects.

Changelog

  • Fixed: Fixed warning "Runtime Network Prefabs was not empty at initialization time." being erroneously logged when no runtime network prefabs had been added
  • Changed: Adding network prefabs before NetworkManager initialization is now supported.

Testing and Documentation

  • Includes unit tests.
  • No documentation changes or additions were necessary.

Also, makes adding prefabs before initializing the list no longer an error case - those prefabs are stored in a separate list so that during initialization, they can be re-added to the prefabs list after pulling in data from the NetworkPrefabsList ScriptableObjects.
@ShadauxCat ShadauxCat requested a review from a team as a code owner May 19, 2023 23:12
ShadauxCat and others added 2 commits May 19, 2023 18:13
Re-ordering the changelog entries
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) May 20, 2023 00:50
@NoelStephensUnity NoelStephensUnity merged commit e11cf0a into develop May 20, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/handle_prefab_double_initialize branch May 20, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants